Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18149 to 7.x: Fix broken x-pack/filebeat tests #18210

Merged
merged 1 commit into from
May 5, 2020

Conversation

andrewkroh
Copy link
Member

Cherry-pick of PR #18149 to 7.x branch. Original message:

What does this PR do?

The tests are failing due to the change in #16784. The fields key is referenced in
system tests so it needs to be present. This adds the key back.

Why is it important?

master is broken so no new work can be merged.

The tests are failing due to the change in elastic#16784. The `fields` key is referenced in
system tests so it needs to be present.

(cherry picked from commit 3024b66)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@andrewkroh andrewkroh requested a review from dedemorton May 4, 2020 21:41
@andrewkroh andrewkroh added Team:Integrations Label for the Integrations team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 1177
Skipped 124
Total 1301

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@andrewkroh andrewkroh merged commit fc49b2f into elastic:7.x May 5, 2020
@andrewkroh andrewkroh deleted the backport_18149_7.x branch January 14, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants